FPS counter updating multiple time per second, is that okey? #1

Open
opened 2022-11-23 14:30:32 +00:00 by Nillx · 20 comments

Noticed that my FPS counter is updating extremely quickly, way faster than the blizz FPS counter (ctr+R). Could that cause some kind of performance issue?

Noticed that my FPS counter is updating extremely quickly, way faster than the blizz FPS counter (ctr+R). Could that cause some kind of performance issue?
Owner

It is computed every 2 seconds or when you renew the tooltip.
Never noticed a heavy cpu load with this.

It is computed every 2 seconds or when you renew the tooltip. Never noticed a heavy cpu load with this.
Author

Interesting, it was changing like multiple time per second earlier when i was waiting for a world boss.

Interesting, it was changing like multiple time per second earlier when i was waiting for a world boss.
Owner

Looking at the code again it might be that multiple instances of the update process could be started and since every process restarts a 2 seconds timer this could cause higher update rate. I'll rewrite this to make sure only one process is running.

Looking at the code again it might be that multiple instances of the update process could be started and since every process restarts a 2 seconds timer this could cause higher update rate. I'll rewrite this to make sure only one process is running.
Author

Yeah its fine after a /reload but after a few seconds it starts updating really fast again.

Yeah its fine after a /reload but after a few seconds it starts updating really fast again.
Author

Also what do you think about FPS and Latency numbers changing color similar to the repair module? Low FPS/latency = Green, higher one yellow, orange or red.

Also what do you think about FPS and Latency numbers changing color similar to the repair module? Low FPS/latency = Green, higher one yellow, orange or red.
Owner

Doable, but this needs many settings. Since magnitude of FPS/Latency value is mainly a personal preference. Will take a while.

Doable, but this needs many settings. Since magnitude of FPS/Latency value is mainly a personal preference. Will take a while.
robin added the
bug
enhancement
labels 2022-11-23 18:36:36 +00:00
Author

No problem then.

No problem then.
Owner

Bug should be fixed. Please check if the fps update rate is okay now.
Enhancement is implemented. In expert mode you have color settings for low, medium and high. The code checks if the value is lower or equal than low and uses the low color. The other colors are used when the value is higher. For values higher than low and lower than medium the default color is used.

Update is pending.

Bug should be fixed. Please check if the fps update rate is okay now. Enhancement is implemented. In expert mode you have color settings for low, medium and high. The code checks if the value is lower or equal than low and uses the low color. The other colors are used when the value is higher. For values higher than low and lower than medium the default color is used. Update is pending.
Owner

Damn, needs another update later today. I have used the wrong colorname for high latency check. So it will change the fps color when latency is high.

Damn, needs another update later today. I have used the wrong colorname for high latency check. So it will change the fps color when latency is high.
Author

Thanks, i tested it and the color settinges does not apply at all to the latency. FPS colors work great.

Also is it possible to change the color only on the numbers, FPS/ms numbers should not change the color so you can change them separately.

Uploaded an edited pic how i would like to make it look. Default color is white and the number colors are changing based on the values. Low fps = blue (high fps = blue) medium = yellow and high/low latency/fps = red.

Thanks, i tested it and the color settinges does not apply at all to the latency. FPS colors work great. Also is it possible to change the color only on the numbers, FPS/ms numbers should not change the color so you can change them separately. Uploaded an edited pic how i would like to make it look. Default color is white and the number colors are changing based on the values. Low fps = blue (high fps = blue) medium = yellow and high/low latency/fps = red.
Owner

Yes, thats possible. I'll take another look at the latency issue. But first some familystuff ;)

Yes, thats possible. I'll take another look at the latency issue. But first some familystuff ;)
Author

Thanks and no problem.

Thanks and no problem.
Owner

Okay, update pending. I added %home so you can configure both latencies in your ldb string. %home and %latency both share the color settings but are colored each individually. Color is applied only to the number not the string part.

Okay, update pending. I added %home so you can configure both latencies in your ldb string. %home and %latency both share the color settings but are colored each individually. Color is applied only to the number not the string part.
Author

Great thank you for adding that

Great thank you for adding that
Author

This are my setting and this is how i see it in game. image

Shouldnt the latency number be in the selected color? And also the "ms" letters are missing and i cannot add them back. (they are missing on the FPS module as well)

image

This are my setting and this is how i see it in game. ![image](/attachments/609bd197-333f-4144-be71-5eb57dfaad87) Shouldnt the latency number be in the selected color? And also the "ms" letters are missing and i cannot add them back. (they are missing on the FPS module as well) ![image](/attachments/886e285f-a44c-48d8-b45b-55c837d42f15)
6.1 KiB
256 KiB
Owner

Guess its badly documented. The textfield is used for the tooltip.
The string used for the ldb-display is configured in the LDB-tab.

Guess its badly documented. The textfield is used for the tooltip. The string used for the ldb-display is configured in the LDB-tab.
Owner

And the latency is higher than the low value and lower than the medium value.
So the default color is used.

And the latency is higher than the low value and lower than the medium value. So the default color is used.
Author

Got it now, thanks. Works perfect. image

Got it now, thanks. Works perfect. ![image](/attachments/03849d32-b76b-457d-8971-058398669097)
Owner

But thinking about it seems I should rework this to use the Latency-String when building the LDB-String. Seems I totally messed this up when rewriting this. But this makes coloring more difficult. I'll take another look at this tomorrow.
So you might have to reconfigure the text fields again after the next update.

But thinking about it seems I should rework this to use the Latency-String when building the LDB-String. Seems I totally messed this up when rewriting this. But this makes coloring more difficult. I'll take another look at this tomorrow. So you might have to reconfigure the text fields again after the next update.
Author

Yeah it was a bit confusing at first glance.

Yeah it was a bit confusing at first glance.
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: rilgamon/zz_Infoclock#1
No description provided.